build: update deno2node, fix docs, add suggestions to sendDice #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the formatting? |
|
Hang on, it's actually not related to these changes, I'll investigate |
|
I guess we can just disable the lint until we support |
KnorpelSenf
changed the title
|
@rayz1065 please consider signing your commits in the future. We usually require this from all contributions, but I made an exception now and merged anyway. @all-contributors add @rayz1065 for the idea and the code! |
|
I've put up a pull request to add @rayz1065! 🎉 |
KnorpelSenf
referenced
this pull request
in grammyjs/types
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSDocs for
api.sendDiceandctx.replyWithDicewere missing '🎳' so I brought them up to date with the latest changes on https://core.telegram.org/bots/api#senddice.I also added suggestions for the parameter
emojifollowing the style insendChatAction. It might be reasonable to remove| (string & Record<never, never>)but I didn't want to introduce a breaking change.I also fixed two JSDocs with an incorrect link to the documentation.